qdmr: init at 0.11.2, added janik as maintainer #209733
Conversation
ofborg
bot
added
8.has: package (new)
github-actions
bot
added
6.topic: nixos
|
If no one has anything else to improve on I think it's ready to be merged, the package was tested with hardware and is working as expected. |
|
Just changed the order of the phases to match the wiki |
|
Tested and pushed the 0.11.1 hotfix if no one has anything to improve anymore we can now finally merge |
Janik-Haag
changed the title
|
Result of 1 package blacklisted:
1 package built:
|
|
Failing on darwin |
|
Edit: Pateched the docbook file, and got manpages working now 🎉 Original Message: |
Janik-Haag
changed the title
github-actions
bot
added
8.has: changelog
8.has: documentation
| { | ||
| lib, | ||
| stdenv, | ||
| fetchFromGitHub, | ||
| installShellFiles, | ||
| writeText, | ||
| cmake, | ||
| libxslt, | ||
| docbook_xsl_ns, | ||
| wrapQtAppsHook, | ||
| libusb1, | ||
| libyamlcpp, | ||
| qtlocation, | ||
| qtserialport, | ||
| qttools, | ||
| qtbase, | ||
| }: |
There was a problem hiding this comment.
We don't format things with alejandra. Use either nixfmt or nixpkgs-fmt.
There was a problem hiding this comment.
Aha, what makes you say that these two are okay, but alejandra isn't? Apparently I've missed the memo about allowed and forbidden formatters in nixpkgs.
There was a problem hiding this comment.
@SuperSandro2000 This has not been decided yet, but the actively-discussed RFC 101 is about this. Contrary to what you're saying though, the shepherd team (which I'm part of) is tending towards alejandra, not away from it. So until the RFC is over, please don't tell people what formatter they should use.
There was a problem hiding this comment.
If we are actively using two contradicting formatters it will be a complete mess.
Also the rfc is now almost open for almost 20 months and lost itself in endless, unproductive discussion also known as bikesheeding.
We are saying it will be there for many months but it is not really feeling like it is coming in the next month(s).
There was a problem hiding this comment.
It literally just had a meeting today -- there is momentum.
There was a problem hiding this comment.
Since there currently is no specified formatting that has to be used I will leave it with the current formatting.
There was a problem hiding this comment.
We haven't standardised on a single formatting program, but there actually is a specified formatting in this case, in the Nixpkgs manual:
Function formal arguments are written as:
{ arg1, arg2, arg3 }:but if they don't fit on one line they're written as:
{ arg1, arg2, arg3 , arg4, ... , # Some comment... argN }:
| let | ||
| inherit (stdenv) isLinux; | ||
| in | ||
|
|
There was a problem hiding this comment.
stdenv can just be written next to isLinux.
Janik-Haag
added
12. first-time contribution
Description of changes
Added qdmr to nixpkgs
Closes #191508
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes