Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse,mautrix-facebook: fix runtime inclusion of python3 systemd #212391

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

chvp
Copy link
Member

@chvp chvp commented Jan 24, 2023

Description of changes

#192197 broke these packages by adding systemd as a dependency. This meant that the included package was no longer the python3 systemd package, but the general systemd derivation. This broke the packages at runtime. This PR fixes that.

I also checked all other derivations touched by #192197, but these were the only were the systemd dependency was added erroneously.

Things done

Deployed this to my server and checked that it worked for matrix-synapse. I don't run mautrix-facebook, so I couldn't verify that.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

…temd

NixOS#192197 broke these packages by adding
systemd as a dependency. This meant that the included package was no longer the
python3 systemd package, but the general systemd derivation. This broke the
packages at runtime. This PR fixes that.
@chvp
Copy link
Member Author

chvp commented Jan 24, 2023

@ofborg test matrix-synapse

@K900 K900 merged commit 9b49161 into NixOS:master Jan 24, 2023
@chvp chvp deleted the fix/matrix-synapse-systemd branch January 24, 2023 13:02
@SuperSandro2000
Copy link
Member

I am wondering myself why this easy to spot mistake was not caught in review.

@ghost
Copy link

ghost commented Jan 27, 2023

This was my fault, I screwed up. Thank you for cleaning up the mess.

I am wondering myself why this easy to spot mistake was not caught in review.

Because it's not easy to spot. The systemd there comes from a with python3.pkgs. Dynamic scoping (with) is fundamentally error prone. The with construct should be avoided when possible, and applied to small subexpressions (not entire derivations) elsewhere.

But crapping on reviewers here is not cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants