-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dontmerge: stdenv: test regression on staging #213454
Conversation
@ofborg build icu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this commit is wrong; I don't see any of my commits in here.
I've squashed your commits in the commit that references your PR. I guess it's still OK since this PR is for testing. |
It's impossible for anybody else to figure out what you've done. Changing the authorship on other peoples' commits is not OK. |
Okay, I'll rebase. |
@ofborg build stdenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see #206907 anywhere in the commit history of this PR, as you claimed here.
As I pointed out, #206907 isn't rebased past #213185 so there is no way to make a clean comparison without mangling one PR or the other.
That's why we wait for them to once again have a common ancestor. This will have to happen in order for one of them to merge and the other to be merge-eligible.
#206907 has nothing to do with stdenv except for the one-line bump. Correct me if I'm wrong. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes