Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport staging-22.11] gtk3: add missing libXdamage #214874

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 6, 2023

Bot-based backport to staging-22.11, triggered by a label in #207821.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

@github-actions github-actions bot mentioned this pull request Feb 6, 2023
2 tasks
libXdamage is an optional dependency, however this is needed for XEmbed
tray icons on MATE to work properly. This is already enabled in gtk4.

https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.36/meson.build#L583
https://gitlab.gnome.org/search?search=xdamage&project_id=665&group_id=8&search_code=true&repository_ref=gtk-3-24

Also explicitly add libXfixes since gtk3 also optionally directly depends
on it.

https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.36/meson.build#L577
(cherry picked from commit 6257a5a)
@bobby285271 bobby285271 marked this pull request as draft February 6, 2023 05:53
@bobby285271 bobby285271 force-pushed the backport-207821-to-staging-22.11 branch from b812b7f to e41c400 Compare February 6, 2023 05:53
@bobby285271 bobby285271 changed the base branch from staging-22.11 to release-22.11 February 6, 2023 05:54
@bobby285271
Copy link
Member

(Want to get ofborg feedback fast)

@ofborg build gtk3

@bobby285271
Copy link
Member

@ofborg build gtk3 gtk3.passthru.tests

@bobby285271 bobby285271 merged commit 1e5a0ec into staging-22.11 Feb 6, 2023
@bobby285271 bobby285271 deleted the backport-207821-to-staging-22.11 branch February 6, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant