treewide: move NIX_CFLAGS_COMPILE to the env attrset

[Artturin]

Description of changes

with structuredAttrs lists will be bash arrays which cannot be exported
which will be a issue with some patches and some wrappers like cc-wrapper

Previous unmerged structuredAttrs and env PRs have done the same thing #76732

other variables that will have to be transferred (in separate PRs)

NIX_CFLAGS_LINK
NIX_LDFLAGS
NIX_PATH

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[wegank]

Looks like passing env.NIX_CFLAGS_COMPILE through overrideDerivation is causing errors:

$ nix-build -A rPackages.data_table
error: cannot coerce a set to a string

       at /.../nixpkgs/pkgs/development/r-modules/default.nix:978:7:

          977|     data_table = old.data_table.overrideDerivation (attrs: {
          978|       env.NIX_CFLAGS_COMPILE = attrs.NIX_CFLAGS_COMPILE + " -fopenmp";
             |       ^
          979|       patchPhase = "patchShebangs configure";
(use '--show-trace' to show detailed location information)

Also for emscriptenPackages.zlib.

[Artturin]

They should be changed to use overrideAttrs https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideDerivation

Do not use this function in Nixpkgs as it evaluates a Derivation before modifying it, which breaks package abstraction and removes error-checking of function arguments

i can do it, should be a simple replacement

[7c6f434c]

978| env.NIX_CFLAGS_COMPILE = attrs.NIX_CFLAGS_COMPILE + " -fopenmp"; | ^

Hm, why this «env.»? It is a plain top-level string in attrs, so it should be a plain top-level string in the output of your override function.

[wegank]

Aha! attrs.NIX_CFLAGS_COMPILE should be attrs.env.NIX_CFLAGS_COMPILE instead.

[Atemu]

$ nix-build -A glm
error: The ‘env’ attribute set can only contain derivation, string, boolean or integer attributes. The ‘NIX_CFLAGS_COMPILE’ attribute is of type list.
(use '--show-trace' to show detailed location information)

I take it this makes it impossible to use a list of strings for cflags?

[Artturin]

$ nix-build -A glm
error: The ‘env’ attribute set can only contain derivation, string, boolean or integer attributes. The ‘NIX_CFLAGS_COMPILE’ attribute is of type list.
(use '--show-trace' to show detailed location information)

I take it this makes it impossible to use a list of strings for cflags?

see commit messages

[Artturin]

rPackages emscriptenPackages fixes #217870

appears to be a problem in only those sets

checked with git diff --name-only @ @~6 | xargs rg overrideDerivation on this branch

[Artturin]

with #217962 commits other than treewide: move NIX_CFLAGS_COMPILE to the env attrset could be reverted (other than some manual fixups