Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: fix libgccjit cross #217874

Closed
wants to merge 3 commits into from
Closed

gcc: fix libgccjit cross #217874

wants to merge 3 commits into from

Commits on Jul 1, 2023

  1. gcc: fix libgccjit cross: enablePlugin=true 

    Before this commit, `pkgsCross.*.libgccjit` would fail to build.
Apparently `--enable-lang=jit` requires `--enable-plugin`, but the
configury is unaware of this requirement.  The failure mode is
difficult to diagnose; the build fails with a compile error due to
`<dlfcn.h>` not being included.

This commit adds `enablePlugin=true` and an `assert` to check for
the unsupported combination and provide feedback at eval time.
    Adam Joseph committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    999aab6 View commit details
    Browse the repository at this point in the history

  2. gcc: fix libgccjit cross: pass libcCross, threadsCross 

    Before this commit, `pkgsCross.*.libgccjit` would fail because
libcCross and threadsCross were not being passed to libgccjit in
all-packages.nix.  These are boilerplate parameters that are
repeated several times in all-packages.nix, so at some point we
should probably make them default arguments of
gcc/${version}/default.nix.

This commit fixes the problem by passing the missing parameters.
    Adam Joseph committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    d5898f0 View commit details
    Browse the repository at this point in the history

  3. [DONTMERGE] gcc: patch to make cross-build of libcc1 work 

    This patch needs to go upstream.  Also the logic around
autoreconfHook needs to be cleaned up; we should try to
autoreconfHook whenever possible (basically everywhere except xgcc)
but I need to work out exactly how to do that.
    Adam Joseph committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    7719a88 View commit details
    Browse the repository at this point in the history