-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baresip: use cmake for configurePhase, fixes cross #218525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although libre is a cmake-based project, our expression for this library does not currently use cmake for the configurePhase. This commit causes it to do so. This is necessary to get downstream libre and baresip to cross-compile.
Although librem is a cmake-based project, our expression for this library does not currently use cmake for the configurePhase. This commit causes it to do so. This is necessary to get downstream libre and baresip to cross-compile.
@ofborg build pkgsCross.aarch64-multiplatform.baresip |
ofborg
bot
added
the
6.topic: cross-compilation
Building packages on a different platform than they will be used on
label
Feb 26, 2023
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Feb 26, 2023
@ofborg build pkgsCross.aarch64-multiplatform.baresip |
ghost
marked this pull request as ready for review
March 16, 2023 02:32
@ofborg build baresip |
ghost
mentioned this pull request
Mar 16, 2023
ehmry
approved these changes
Mar 19, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: cross-compilation
Building packages on a different platform than they will be used on
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Although baresip is a cmake-based project, our expression was not using cmake for the configurePhase. This commit causes it to do so, which fixes cross-compilation for this package.
Incorporates:
Closes #220762
Things done