v4l-utils: move wrapQtAppsHook to buildInputs #220431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapQtAppsHook is currently in nativeBuildInputs, which causes it to attempt to use the buildPlatform's QT libraries. Let's fix cross by moving it to buildInputs.
ghost
mentioned this pull request
|
hooks should go in nativeBuildInputs so this is a bug somewhere else perhaps here nixpkgs/pkgs/development/libraries/qt-5/5.15/default.nix Lines 226 to 227 in 0c4800d https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md |
|
Yeah this PR is definitely broken. |
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapQtAppsHook is currently in nativeBuildInputs, which causes it to
attempt to use the buildPlatform's QT libraries. Let's fix cross by
moving it to buildInputs.