Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libidn2: 2.3.2 -> 2.3.4 #221687

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

henrirosten
Copy link
Member

Description of changes

Update libidn2 to current latest version, see: https://lists.gnu.org/archive/html/info-gnu/2022-10/msg00004.html and https://gitlab.com/libidn/libidn2/-/releases.

This change was motivated by manual test run of https://github.com/tiiuae/sbomnix/tree/main/scripts/nixupdate, which pointed out that libidn2 is currently not up-to-date in nix unstable.

Manual update attempt using the earlier mirror mirror://gnu/libidn/ failed due to:

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
do not know how to unpack source archive /nix/store/1v5l3gnb0j8ckwv6ms17gl4b6g5nbx3j-libidn2-2.3.4.tar.gz

Which is assumably the same reason why r-ryantm also failed to automatically update: https://r.ryantm.com/log/libidn2/2023-03-05.log.

It's not fully clear why changing the mirror to master repository (https://ftp.gnu.org/pub/gnu/) resolves the update issue.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/47

@trofi trofi merged commit 4d8ca6c into NixOS:staging Mar 31, 2023
@trofi
Copy link
Contributor

trofi commented Mar 31, 2023

Pulled as is. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants