-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staging-next 2023-04-05 #224806
staging-next 2023-04-05 #224806
Conversation
regression for |
Yes, rustc upgrade caused a few packages to fail to build. As always, as far as I remember. |
sequoia upstream has a patch which seems to fix this. our sequoia package is already one version behind, so i'll throw up a PR against master later today to update it in a way which also unbreaks it for staging-next. |
upstream changelog: <https://gitlab.com/sequoia-pgp/sequoia/-/compare/sq%2Fv0.27.0...sq%2Fv0.28.0> changes to the nix package: - removes the cherry-picked 7916f90421 patch that made it into 0.28.0 - cherry-picks upstream commit 4dc6e624c2 which adds support for newer rust versions but didn't make the 0.28.0 release. see <#224806> - adds an update script. future routine updates can be automated with `nix-shell maintainers/scripts/update.nix --argstr package sequoia`
This fixes parts in llvmPackages_{13,rocm} e.g. build .clang for testing. Longterm mass-rebuild fix should come in PR #225846
This part got forgotten in commit ac3acd9.
...into staging-next In particular, this fixes build after rustc upgrade.
It's weird but this single test started failing in this staging-next iteration, on all four 64-bit platforms. I thought this will be better than not having any grafana, as it's only a single test and our .tests still build.
I think all major issues were resolved, even though some just in a temporary hacky way. |
@@ -31,6 +32,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
libdrm | |||
numactl | |||
valgrind | |||
gcc.cc.libgcc # TODO: unhack this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to have broken ofborg: https://gist.github.com/GrahamcOfBorg/40ca8430db607680613622feb27f7d4d#file-output-path-comparison-L222
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm sorry. Some people run into this unexpected strictness (evaluating even on platforms that are unsupported/broken for the package). Hopefully it will be OK now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try #225846 it is the proper fix for this.
Fixed by: |
d0bb9ed is causing CI to fail for all PRs targeting |
For reference, that commit was amended in fe2ecaf which should fix the CI. |
Binaries generated by crate2nix (buildRustCrate) are much bigger after this staging iteration, debug and release are affected. I've tested on some internal crate. Commit before merge
After merge:
|
Perhaps bring that up on more specific places, e.g. PR #220373 |
Before #210843
Please post a complete reproducer in #210843 if it was the cause; if not, please open a new issue and reference it here. Because github is still stuck in the 1970s, before the world discovered threaded discussions. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@trofi this |
I posted the comment in the wring branch as github UI shown only this branch as a source branch. I realized it too late and re-posted comment to the intended branch that I suspect caused the regression. I marked comments here as hidden as Obsolete because they are not directly relevant to this PR. |
Helpful links
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
Mass breakages
python3Packages.scikit-learn
(both python versions on*-linux
) https://hydra.nixos.org/build/21519583446f29d4 (just workaround for now)
accelerate
framework (and failing to find it)https://hydra.nixos.org/build/215252174#tabs-buildsteps
https://hydra.nixos.org/build/215284720
opencv, mpv: add Accelerate framework on darwin #225378
llvmPackages_*
got brokenby glibc upgrade (most likely)https://hydra.nixos.org/build/214886749
https://hydra.nixos.org/build/215014044
stdenv: Nix-driven bootstrap of gcc #209870 (comment)