default-crate-overrides.nix: prevent git fetch
#224893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figsoda
approved these changes
Apr 5, 2023
ofborg
bot
added
6.topic: cross-compilation
ghost
marked this pull request as draft
ghost
changed the title
git fetch
The build.rs script shipped with evdev-sys attempts to detect cross compilation and uses a completely different codepath which does a `git fetch` inside the build script. This doesn't work in nixpkgs. This PR adds a `touch libevdev/.git` to trick the `build.rs` into thinking that it is not necessary to do a `git fetch`. Thanks to @figsoda for finding this more-elegant solution to the problem (my original solution needed to patch `build.rs`): #224893 (review) Tested on: - [x] `aarch64-linux` (cross from `x86_64-linux`)
ghost
marked this pull request as ready for review
figsoda
reviewed
Apr 6, 2023
figsoda
approved these changes
Apr 9, 2023
jackyliu16
pushed a commit
to jackyliu16/nixpkgs
that referenced
this pull request
Apr 22, 2023
The build.rs script shipped with evdev-sys attempts to detect cross compilation and uses a completely different codepath which does a `git fetch` inside the build script. This doesn't work in nixpkgs. This PR adds a `touch libevdev/.git` to trick the `build.rs` into thinking that it is not necessary to do a `git fetch`. Thanks to @figsoda for finding this more-elegant solution to the problem (my original solution needed to patch `build.rs`): NixOS#224893 (review) Tested on: - [x] `aarch64-linux` (cross from `x86_64-linux`)
jackyliu16
pushed a commit
to jackyliu16/nixpkgs
that referenced
this pull request
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build.rs script shipped with evdev-sys attempts to detect cross compilation and uses a completely different codepath which does a
git fetchinside the build script. This doesn't work in nixpkgs.This PR adds a
touch libevdev/.gitto trick thebuild.rsinto thinking that it is not necessary to do agit fetch.Thanks to @figsoda for finding this more-elegant solution to the problem (my original solution needed to patch
build.rs):#224893 (review)
Tested on:
aarch64-linux(cross fromx86_64-linux)