-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zathura: disable tests if cross #224903
zathura: disable tests if cross #224903
Conversation
@ofborg build pkgsCross.aarch64-multiplatform.zathura |
Since this changes nothing for native builds, but at least builds for aarch64 on x86-64 (tested with #224901), I'm not opposed to merging this, but I'd strongly prefer fixing the stuff that does not work over disabling it:
|
Done: 20860bf1129d1290de20bf378968720ce1105fb1 Note: it's easier to keep track of requests like this if you leave them as resolvable review comments.
I left a review. |
If ofborg is successful with the two builds I asked it to do in #223303, I adjust this PR to keep texlive for cross builds. |
Squashing... |
@ofborg build pkgsCross.aarch64-multiplatform.zathura |
The only part of zathura that won't cross compile is the tests. Let's disable these so the binaries at least can be cross-built. This commit also adds `check` to `buildInputs` and fixes the reference to `sphinx`. Co-authored-by: apfelkuchen6 <73002165+apfelkuchen6@users.noreply.github.com> Co-authored-by: Artturi <Artturin@artturin.com>
@ofborg build pkgsCross.aarch64-multiplatform.zathura |
Rebased, no other changes. @ofborg build pkgsCross.aarch64-multiplatform.zathura |
Ah right, this won't cross-build on |
The only part of zathura that won't cross compile is the documentation and tests. Also, the dependency for synctex support (texlive) doesn't cross compile.