Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chafa: fix cross-compilation #224923

Merged
1 commit merged into from Apr 13, 2023
Merged

chafa: fix cross-compilation #224923

1 commit merged into from Apr 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2023

No description provided.

@ghost
Copy link
Author

ghost commented Apr 6, 2023

@ofborg build pkgsCross.aarch64-multiplatform.chafa

@ghost ghost added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Apr 6, 2023
@ofborg ofborg bot requested a review from mogorman April 6, 2023 03:24
@@ -31,7 +32,9 @@ stdenv.mkDerivation rec {
patches = [ ./xmlcatalog_patch.patch ];

preConfigure = ''
./autogen.sh
substituteInPlace ./autogen.sh --replace pkg-config '$PKGCONFIG'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or $PKG_CONFIG? Which is set by stdenv.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested after applying #225360

@ghost
Copy link
Author

ghost commented Apr 13, 2023

(Re)built on:

  • x86_64-linux (native)
  • aarch64-linux (cross from x86_64-linux)

@ghost ghost merged commit 96ba1c5 into NixOS:master Apr 13, 2023
@ghost ghost deleted the pr/chafa/cross branch April 13, 2023 03:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants