dante: disable getaddrinfo() checks if cross #224929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
6.topic: cross-compilation
Artturin
reviewed
Apr 7, 2023
ghost
requested a review
from 
Prior to this commit, dante's configure-time getaddrinfo() checks were disabled only if stdenv.hostPlatform.isMips64. These checks must also be disabled if the buildPlatform cannot execute hostPlatform binaries. This commit factors out the control of this disablement as a flag and adds an additional situation in which that flag is enabled.
Artturin
approved these changes
Apr 22, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR contains three changes to
dantewhich would merge-conflict with each other if submitted separately.The first commit fixes breakage resulting from a recent upgrade to autoconf:
The second commit runs
autoreconfHookunconditionally, rather than only on one platform, so we notice problems more quickly:The third change expands the set of conditions under which we bypass dante's configure-time
getaddrinfo()check to include not only mips native builds, but also all cross builds. The bypass is required in both cases: