stdenv/linux: fix patchelf confusion #224945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2023 22:18
The stage before `xgcc` creates the first compiled patchelf (i.e. not from bootstrapFiles). The `xgcc` stage was inadvertently switching *back* to using the patchelf *from* the bootstrapFiles. The first commit in this PR adds self-checking comments (assertions) to make it clear where each stage's patchelf comes from. The second commit fixes the bug, and updates the self-checking comments.
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
trofi
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stage before
xgcccreates the first compiled patchelf (i.e. not from bootstrapFiles).The
xgccstage was inadvertently switching back to using the patchelf from the bootstrapFiles.The first commit in this PR adds self-checking comments (assertions) to make it clear where each stage's patchelf comes from.
The second commit fixes the bug, and updates the self-checking comments.