texlive/bin: remove unnecessary parentheses #225035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python310Packages.sphinx-autodoc-typehints: 1.23.4 -> 1.22
…d empty meta.maintainers, misc cleanup
roc-toolkit: 0.2.1 -> 0.2.3
iana-etc: 20221107 -> 20230316
...into staging
Failing Hydra build: https://hydra.nixos.org/build/189053872
Previously, builds such as `cmake` would fail with errors like this:
In file included from /nix/store/injyphmxqgi028skp28fsmdvbdb57nvl-glibc-2.36-48-dev/include/linux/fs.h:19,
from /build/cmake-3.24.2/Utilities/cmlibarchive/libarchive/archive_read_disk_posix.c:56:
/nix/store/injyphmxqgi028skp28fsmdvbdb57nvl-glibc-2.36-48-dev/include/linux/mount.h:95:6: error: redeclaration of 'enum fsconfig_command'
95 | enum fsconfig_command {
| ^~~~~~~~~~~~~~~~
The reason behind that is that the kernel exports `linux/mount.h` via
kernel headers APIs that are also defined in `sys/mount.h` from glibc.
To avoid clashes, safeguards were implemented in glibc to prevent this
from happening[1][2].
However, these `#ifndef`-safeguards are removed by `fixincludes` during
gcc's build and the (broken) result is subsequently copied into
`include-fixed/sys/mount.h` which is added to each build via the
cc-wrapper. To work around this, I decided to simply drop the file: it
also exists in glibc's output and our gcc12 doesn't seem to expose this
anymore anyways.
[1] Commit bb1e8b0ca99b5cbedfae3e6245528a87d95ff3e2
[2] Commit 3bd3c612e98a53ce60ed972f5cd2b90628b3cba5
Failing Hydra build: https://hydra.nixos.org/build/193327405 Same fix as for gcc11.
Failing Hydra build: https://hydra.nixos.org/build/193342322 Patch from gcc11 requires some minor adjustments to properly apply.
Failing Hydra build: https://hydra.nixos.org/build/193370420
Failing Hydra build: https://hydra.nixos.org/build/193340626
ghost
requested review from
ttuegel,
matthewbauer,
winterqt,
figsoda,
marsam,
stigtsp,
zakame,
dasJ,
a team and
Ericson2314
as code owners
ghost
mentioned this pull request
15 tasks
github-actions
bot
added
6.topic: emacs
ghost
closed this
|
Sorry |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here:
#223303 (review)
These parentheses are unnecessary. No change to eval.