Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlyne: 0.2.1 -> 0.3.1 #230685

Merged
merged 1 commit into from
May 10, 2023
Merged

inlyne: 0.2.1 -> 0.3.1 #230685

merged 1 commit into from
May 10, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented May 8, 2023

Diff: Inlyne-Project/inlyne@v0.2.1...v0.3.1

Changelog: https://github.com/trimental/inlyne/releases/tag/v0.3.1

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@CosmicHorrorDev
Copy link
Contributor

Thanks for packaging inlyne (among many other things)!

I just wanted to let you know that there is now support for generating shell completions (CI is ignoring it for aarch64-apple atm because invoking the executable for it errors on a bad CPU type for some reason)

https://github.com/trimental/inlyne/blob/f372ffd38bc6612be525178ef6ed1841c2c353a6/.github/workflows/release.yml#L72-L76

Currently it's done by invoking the executable, but this will likely be moved to something like cargo-xtask in the future

@figsoda
Copy link
Member Author

figsoda commented May 9, 2023

I ran into an issue when trying to use the fish completions:

complete: too many arguments

result/share/fish/vendor_completions.d/inlyne.fish (line 4): 
complete -c inlyne -s w -l page width -d 'Maximum width of page in pixels' -r
^
from sourcing file result/share/fish/vendor_completions.d/inlyne.fish

(Type 'help complete' for related documentation)

Inlyne-Project/inlyne#98 should be able to fix this

@wegank
Copy link
Member

wegank commented May 9, 2023

Result of nixpkgs-review pr 230685 run on aarch64-darwin 1

1 package built:
  • inlyne

@figsoda figsoda changed the title inlyne: 0.2.1 -> 0.3.0 inlyne: 0.2.1 -> 0.3.1 May 9, 2023
@wegank wegank merged commit 9330af3 into NixOS:master May 10, 2023
@figsoda figsoda deleted the inlyne branch May 10, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants