Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pods: 1.2.1 -> 1.2.2 #235461

Merged
merged 1 commit into from
Jun 2, 2023
Merged

pods: 1.2.1 -> 1.2.2 #235461

merged 1 commit into from
Jun 2, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Jun 1, 2023

Diff: marhkb/pods@v1.2.1...v1.2.2

Changelog: https://github.com/marhkb/pods/releases/tag/v1.2.2

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 1, 2023
@NickCao NickCao merged commit a898a93 into NixOS:master Jun 2, 2023
@figsoda figsoda deleted the pods branch June 2, 2023 02:31
@meppu
Copy link
Contributor

meppu commented Jul 6, 2023

I just wanted to notify that it fails to build this package from source. The issue is here. But basically looks like this package can't be compiled from source with rust 1.70.0 now.

@figsoda
Copy link
Member Author

figsoda commented Jul 6, 2023

We can either pull in rust-lang/rust#112266 or wait for rust 1.71 which will be released on july 13. @nixos/rust @vcunat what do you think?

@meppu
Copy link
Contributor

meppu commented Jul 6, 2023

Since stable channel is not affected, i think just waiting for a week can be ideal 😅

@tjni
Copy link
Contributor

tjni commented Jul 6, 2023

Waiting a week would be my preference too. If we want to unblock, perhaps we could create a temporary patch to apply the workaround described on the linked issue.

@vcunat
Copy link
Member

vcunat commented Jul 6, 2023

(pinged) I don't know rust stuff really. If you're asking about staging-next, one iteration will be starting now but another one probably roughly in a week as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants