Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: convert remaining rust packages with git dependencies to importCargoLock #236308

Closed
wants to merge 11 commits into from

Conversation

raphaelr
Copy link
Contributor

@raphaelr raphaelr commented Jun 6, 2023

Description of changes

Followup of #221716. This PR updates some more packages with git dependencies to importCargoLock (The only remaining package I can find is emacsPackages.tsc; I will update that in a followup PR because it requires changing an update script and thus isn't as trivial as the other packages in this PR).

Currently the cargoDeps of these packages will fail to build with ERROR: The Cargo.lock contains git dependencies. See #217084 for background information.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@yu-re-ka yu-re-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize we had missed so many. looks good 👍🏻

@raphaelr
Copy link
Contributor Author

Rebased to resolve the merge conflict

@pbsds pbsds mentioned this pull request Aug 7, 2023
12 tasks
@raphaelr raphaelr closed this Dec 14, 2023
@raphaelr raphaelr deleted the cargo-lock branch December 14, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants