stdenv: updateAutotoolsGnuConfigScriptsHook unconditionally

[ghost]

Description of changes

Unlike autoreconfHook, updateAutotoolsGnuConfigScriptsHook adds almost no compilations. Therefore, in the interest of building the same source code on every platform wherever possible, let's eliminate the conditional guards around updateAutotoolsGnuConfigScriptsHook in stdenv.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[trofi]

Huge +1 for making it unconditional. Thank you!

[Artturin]

exposed that makeSetupHook is broken in __structuredAttrs __bootPackages

discovered with tests.stdenv.structuredAttrsByDefault.hooks.make-symlinks-relative

$ nix build --impure --expr "with import ./. { config = { structuredAttrsByDefault = true; }; }; stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.libxcrypt"
this derivation will be built:
  /nix/store/994qfy50ylyafndz12zh8zq1a73gi5ll-libxcrypt-4.4.35.drv
building '/nix/store/994qfy50ylyafndz12zh8zq1a73gi5ll-libxcrypt-4.4.35.drv'...
libxcrypt> structuredAttrs is enabled
libxcrypt> unpacking sources
libxcrypt> unpacking source archive /nix/store/spzw99ag9wq184zd9il0n66937m30dzl-libxcrypt-4.4.35.tar.xz
libxcrypt> source root is libxcrypt-4.4.35
libxcrypt> setting SOURCE_DATE_EPOCH to timestamp 1686071870 of file libxcrypt-4.4.35/config.h.in
libxcrypt> patching sources
libxcrypt> updateAutotoolsGnuConfigScriptsPhase
libxcrypt> Updating Autotools / GNU config script to a newer upstream version: ./build-aux/m4-autogen/config.sub
libxcrypt> cp: cannot stat '@gnu_config@/config.sub': No such file or directory

nix build --impure --expr "with import ./. { config = { structuredAttrsByDefault = true; }; }; stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.updateAutotoolsGnuConfigScriptsHook"