Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/system: move toLosslessStringMaybe into lib/tests #239132

Merged
1 commit merged into from Jun 23, 2023
Merged

lib/system: move toLosslessStringMaybe into lib/tests #239132

1 commit merged into from Jun 23, 2023

Commits on Jun 22, 2023

  1. lib/system: move toLosslessStringMaybe into lib/tests 

    toLosslessStringMaybe is not used by anything other than lib/tests,
so it can be private to that file.

I don't think this function was terribly well thought-through.  If
people start using it, we will become permanently dependent on the
ability to test platforms for equality.  It also makes the
elaboration process more fragile, because it encourages code outside
of nixpkgs to become sensitive to the minute details of how
elaboration happens.
    Adam Joseph committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    00a749a View commit details
    Browse the repository at this point in the history