Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.systems: add gnuabin32 to isGnu #240590

Merged
1 commit merged into from Jun 29, 2023
Merged

lib.systems: add gnuabin32 to isGnu #240590

1 commit merged into from Jun 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2023

Description of changes

The isGnu predicate was missing gnuabin32. This commit corrects that by adding it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The `isGnu` predicate was missing `gnuabin32`.  This commit corrects
that by adding it.
@ghost
Copy link
Author

ghost commented Jun 29, 2023

I'm going to self-merge this without a review because (a) it is trivial and (b) I think I am the only person who cares about the obscure ILP32 ABI on mips.

@ghost ghost merged commit cccd511 into NixOS:master Jun 29, 2023
@ghost ghost deleted the pr/systems/gnuabin32-isgnu branch January 23, 2024 06:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants