Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "nixos/gitea: set service type to notify"" #244856

Closed

Conversation

SuperSandro2000
Copy link
Member

Reverts #244843

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 22, 2023
@RaitoBezarius RaitoBezarius marked this pull request as draft July 22, 2023 16:41
@RaitoBezarius
Copy link
Member

Wait until Forgejo maintainers split the Forgejo module.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review July 22, 2023 16:42
@RaitoBezarius
Copy link
Member

No, this is not the change we accepted to do, you didn't bother reading the discussion, so please do not engage further in that behavior.

@SuperSandro2000
Copy link
Member Author

I don't see a reason here to wait on other people. They can take there time to do things properly and the workaround here is super simple.

@RaitoBezarius
Copy link
Member

I don't see a reason here to wait on other people. They can take there time to do things properly and the workaround here is super simple.

No, we do not need to pile up workarounds in a temporary situations, reverting to simple will not break Gitea.

@bendlas
Copy link
Contributor

bendlas commented Jul 22, 2023

Hey Folks, Neither is Gitea dependent on being on notify, nor can't we override a quickfix later.

I'm sure it's sunny outside somewhere. Why not take a walk, touch grass and smell the flowers for half an hour?

EDIT I know I'll do that for now, before I take a look if my locally forked forgejo module might be applicable.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jul 22, 2023
@SuperSandro2000 SuperSandro2000 deleted the revert-244843-partial-revert-243883-gitea-1200 branch July 22, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants