Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-gcc-version: init #245169

Closed
wants to merge 1 commit into from
Closed

default-gcc-version: init #245169

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2023

Description of changes

This commit lifts the default gcc version to a top-level attribute so it can be overridden.

Detailed motivation can be found here: #244871 (comment)

Closes #244871

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This commit lifts the default gcc version to a top-level attribute
so it can be overridden.
@ghost ghost marked this pull request as ready for review July 24, 2023 11:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 24, 2023
@ghost ghost mentioned this pull request Aug 14, 2023
12 tasks
@ghost
Copy link
Author

ghost commented Aug 15, 2023

Included in #249301 which is a fully-automatic fix for the bug.

@ghost ghost closed this Aug 15, 2023
@ghost ghost deleted the pr/gcc/default-gcc-version branch August 15, 2023 08:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgsCross.aarch64-multiplatform.gcc13 (and other cross-builds) fail to build due to gcc version mismatch
0 participants