Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux.configfile: remove unused kernelTarget attr #245965

Merged
merged 1 commit into from Sep 30, 2023
Merged

linux.configfile: remove unused kernelTarget attr #245965

merged 1 commit into from Sep 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2023

This reapplies #234090 after the revert of #221707 in #245449.

Description of changes

As far as I can tell this is unused since f95d214.

Fixes: f95d214 ("Implement generic kernel build via manual-config")
Fixes: #234084

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

As far as I can tell this is unused since f95d214.

Fixes: f95d214 ("Implement generic kernel build via manual-config")
Fixes: #234084
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Jul 28, 2023
@Artturin Artturin merged commit 425ddf1 into NixOS:staging Sep 30, 2023
8 checks passed
@ghost ghost deleted the pr/linux/kernel/repick2 branch January 23, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants