Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spip: init at unstable-2023-04-19 #247476

Merged
merged 1 commit into from
Jun 24, 2024
Merged

spip: init at unstable-2023-04-19 #247476

merged 1 commit into from
Jun 24, 2024

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Aug 6, 2023

Description of changes

A genomic tool to compute splice preductions, used in germline analysis. This tool is quite popular, open-source and with few dependencies.

Website: https://github.com/raphaelleman/SPiP

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for packaging SPiP.

pkgs/applications/science/biology/spip/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/spip/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
Comment on lines 11 to 19
transcriptome19 = fetchurl {
url = transcriptome-url + "/transcriptome_hg19.RData";
sha256 = "sha256-E8UmHoNoySSIde+TRE6bxVP0PrccpKDvIHBGCvWnYOw=";
};

transcriptome38 = fetchurl {
url = transcriptome-url + "/transcriptome_hg38.RData";
sha256 = "sha256-mQMMZVN1byXMYjFoRdezmoZtnhUur2CHOP/j/pmw8as=";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to other reviewers: downloading these files takes way longer than expected for 800 MB.

pkgs/applications/science/biology/spip/default.nix Outdated Show resolved Hide resolved
@apraga
Copy link
Contributor Author

apraga commented Nov 12, 2023

Not sure why the check "pkgs/by-name" fails but nixpkgs-review works on my end.

A genomic tool to compute splice preductions.
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 247476 run on x86_64-linux 1

1 package built:
  • spip

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2023
@JohnRTitor JohnRTitor changed the title spip: unstable 2022-11-22 spip: init at unstable-2023-04-19 Jun 24, 2024
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 247476 run on x86_64-linux 1

1 package built:
  • spip

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit 759a060 into NixOS:master Jun 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants