Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.systems: add ubootArch #249069

Merged
merged 2 commits into from Sep 30, 2023
Merged

lib.systems: add ubootArch #249069

merged 2 commits into from Sep 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2023

Description of changes

u-boot has its own rosetta stone, almost but not exactly the same as
the Linux kernel's. This commit adds it and the two cases where it
diverges.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Adam Joseph added 2 commits August 14, 2023 01:34
lib.systems: add ubootArch
a0c77ae 
u-boot has its own rosetta stone, almost but not exactly the same as
the Linux kernel's.  This commit adds it and the two cases where it
diverges.
make-initrd-ng: use hostPlatform.ubootArch for uinitrdArch
a97e8fc 
This allows make-initrd-ng to pick up the few cases where Linux and
u-boot disagree.
@github-actions github-actions bot added 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library labels Aug 14, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 14, 2023
@ghost ghost marked this pull request as ready for review August 14, 2023 09:58
@Artturin Artturin merged commit bf25d87 into NixOS:master Sep 30, 2023
7 checks passed
@ghost ghost deleted the pr/lib/systems/ubootArch branch January 23, 2024 06:48
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Artturin