gnu-config: use the unpackPhase, so .overrideAttrs(_:{patches=...}) works #249088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
12 tasks
sternenseemann
approved these changes
Aug 14, 2023
|
Nit: would be |
ghost
changed the title
|
Fixed commit message. |
added 2 commits
August 16, 2023 05:12
…orks
Prior to this PR, gnu-config did its unpacking in the `buildPhase`,
which mean that `.overrideAttrs(_:{ patches = ... })` couldn't be used to
test out patches to `gnu-config`.
This PR fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Prior to this PR, gnu-config did its unpacking in the
buildPhase, which mean that.overrideAttrs(_: { patches = ... })couldn't be used totest out patches tognu-config.This PR fixes that.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)