Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_21: install go.env #250472

Merged
merged 1 commit into from
Aug 21, 2023
Merged

go_1_21: install go.env #250472

merged 1 commit into from
Aug 21, 2023

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 21, 2023

Description of changes

fix build error: "GOPROXY list is not the empty string, but contains no entries"

see: golang/go#57179

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

fix build error: "GOPROXY list is not the empty string, but contains no entries"

see: golang/go#57179
@ofborg ofborg bot requested a review from qbit August 21, 2023 03:42
@zowoq zowoq changed the title fix: install go.env in go_1_21 go_1_21: install go.env Aug 21, 2023
@zowoq zowoq merged commit cbc976a into NixOS:master Aug 21, 2023
@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2023

Thanks!

@yihuang yihuang deleted the master-1 branch August 21, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants