Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "buildGoModule: set GOPROXY to go default" #250492

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Revert "buildGoModule: set GOPROXY to go default" #250492

merged 1 commit into from
Aug 21, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 21, 2023

This reverts commit 3392d56.

Fixed in cbc976a

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested review from kalbasit and Mic92 as code owners August 21, 2023 06:12
@zowoq zowoq mentioned this pull request Aug 21, 2023
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 21, 2023
@zowoq zowoq marked this pull request as draft August 21, 2023 08:31
@zowoq zowoq changed the base branch from staging to master August 21, 2023 08:31
@zowoq zowoq marked this pull request as ready for review August 21, 2023 11:07
@zowoq zowoq merged commit 9b56280 into NixOS:master Aug 21, 2023
@zowoq zowoq deleted the go-revert branch August 21, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: golang 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant