Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-crate-overrides: add libseat-sys #251534

Merged
1 commit merged into from Aug 26, 2023
Merged

default-crate-overrides: add libseat-sys #251534

1 commit merged into from Aug 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2023

Description of changes

This is needed for building cosmic-comp using crate2nix instead of buildRustPackage (like #251365 does).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is needed for building `cosmic-comp` using `crate2nix` instead
of `buildRustPackage` (like
#251365 does).
@ghost ghost marked this pull request as ready for review August 26, 2023 08:50
@ghost ghost requested review from zowoq, winterqt and figsoda as code owners August 26, 2023 08:50
@ghost ghost mentioned this pull request Aug 26, 2023
12 tasks
@ghost ghost merged commit 5237477 into NixOS:master Aug 26, 2023
18 checks passed
@ghost ghost deleted the pr/default-crate-overrides/libseat-sys branch August 26, 2023 11:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant