Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/by-name: Add manual migration guidelines #254632

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

infinisil
Copy link
Member

Description of changes

Motivated from seeing people starting to migrate packages manually when it shouldn't be necessary or where it could be problematic, see

Motivated from seeing people starting to migrate packages manually when
it shouldn't be necessary or done differently.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 11, 2023
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include some deprecation for this text? After all it will lose its raison d'être when the automated migration ends.

@infinisil
Copy link
Member Author

@AndersonTorres Good point, I just added a TODO item in #211832 to be reminded of this, sound good?

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 11, 2023
@infinisil infinisil added this to the RFC 140 milestone Sep 11, 2023
@AndersonTorres
Copy link
Member

Perfect!

@Artturin Artturin merged commit 4d09416 into NixOS:master Sep 12, 2023
8 checks passed
@infinisil infinisil deleted the by-name-guidelines branch September 12, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants