Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I noticed that go 1.21 was merged 2 weeks ago, but nixpkgs still install 1.20.
I'm new to Nix, and definitely don't understand the full extend of this change, but its the only place I found that seemed to make sense to reference go 1.21 instead of 1.20.
Judging by the output of
nix-build --arg pkgs 'import <nixpkgs> {}' -A go
, it seems that is in fact the missing piece.Anyway, thanks for reviewing, and sorry if I'm out of my mind here :)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)