Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: 1.20.7 -> 1.21.1 #254877

Closed
wants to merge 1 commit into from
Closed

go: 1.20.7 -> 1.21.1 #254877

wants to merge 1 commit into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Sep 13, 2023

Description of changes

I noticed that go 1.21 was merged 2 weeks ago, but nixpkgs still install 1.20.

I'm new to Nix, and definitely don't understand the full extend of this change, but its the only place I found that seemed to make sense to reference go 1.21 instead of 1.20.

Judging by the output of nix-build --arg pkgs 'import <nixpkgs> {}' -A go, it seems that is in fact the missing piece.

Anyway, thanks for reviewing, and sorry if I'm out of my mind here :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 mentioned this pull request Sep 13, 2023
12 tasks
@zowoq zowoq marked this pull request as draft September 13, 2023 04:00
@zowoq
Copy link
Contributor

zowoq commented Sep 13, 2023

This has intentionally not been done yet, it's a reasonable amount of work as need to make sure there isn't much breakage.

I'll do this myself in the next week or two, thanks anyway for the PR.

@zowoq zowoq closed this Sep 13, 2023
@caarlos0 caarlos0 deleted the use-go1.21 branch September 13, 2023 04:10
@caarlos0
Copy link
Member Author

ah, ok, let me know if I can help with anything, go-related or otherwise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants