headscale: fix reacting to SIGTERM #254934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
NKJe,
Misterio77,
ghuntley,
kradalby and
06kellyjac
|
FWIW, this fix is now in upstream: |
|
Itd probably be best to fetchPatch the merged commit or wait for the next release if thats set to happen swiftly |
|
I'll wait for the next release |
|
The Next Release has not happened yet and it's been half a year. Should we dig this up? |
|
So it's been another, uh, A While. I'm just going to merge this in a few hours unless someone is opposed. |
The current version of headscale does not react to SIGTERMs and so it can only be terminated by a SIGKILL at the moment. This commit provides a patch to fix this.
K900
force-pushed
the
headscale-sigterm-fix
branch
from
299b8ba
to
37947d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The current version of headscale does not react to SIGTERMs and so it can only be terminated by a SIGKILL at the moment. This PR provides a patch to fix this.
The fix is taken from here. For more information about this, see the related issue here.
I use this fix for my headscale and it works like a charm for weeks now.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)