Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.gitpython: 3.1.33 -> 3.1.37 #256546

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

chkno
Copy link
Member

@chkno chkno commented Sep 21, 2023

Description of changes

This version bump resolves https://nvd.nist.gov/vuln/detail/CVE-2023-41040

Changelogs:

Things done

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

      8 packages failed to build:
      python310Packages.mmcv python310Packages.mmcv.dist python310Packages.skrl python310Packages.skrl.dist
      python311Packages.mmcv python311Packages.mmcv.dist python311Packages.skrl python311Packages.skrl.dist
    
      448 packages built: ...
    

    These build failures are probably not caused by this PR: I'm unable to build these packages on my machine with or without this change because the build fills ram and swap and then earlyoom kills it. :(

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 23.11 Release Notes (or backporting 23.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

FYI: @fabaff, maintainer

@ofborg ofborg bot requested a review from fabaff September 21, 2023 18:20
@fabaff fabaff added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 22, 2023
@risicle
Copy link
Contributor

risicle commented Sep 23, 2023

Looks like they're still refining the patch and 3.1.37 will be out v soon with a better fix.

@LeSuisse
Copy link
Contributor

3.1.37 was released with a "proper fix": https://github.com/gitpython-developers/GitPython/releases/tag/3.1.37

@chkno chkno changed the title python3Packages.gitpython: 3.1.33 -> 3.1.36 python3Packages.gitpython: 3.1.33 -> 3.1.37 Sep 23, 2023
@chkno
Copy link
Member Author

chkno commented Sep 23, 2023

Cool. I've updated this to bump to 3.1.37. Thanks.

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review reveals no new failures for me, macos 10.15 & nixos x86_64

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 25, 2023
@risicle risicle merged commit 73efd62 into NixOS:master Oct 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants