lib.gvariant: make the tests really work #256743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: module system
ofborg
bot
added
10.rebuild-darwin: 0
wegank
approved these changes
Sep 22, 2023
jtojnar
reviewed
Sep 22, 2023
lib/tests/modules/gvariant.nix
Outdated
| mkMerge [ | ||
| { bool = true; } | ||
| examples = with lib.gvariant; | ||
| lib.mkMerge [ |
There was a problem hiding this comment.
Since we are no longer testing the merging functionality, we can just drop the mkMerge and use a single big attribute.
Ideally, we would keep testing merging though (especially for arrays and dictionaries). Even nicer would be also testing the failures to merge but that is harder.
There was a problem hiding this comment.
I removed it. Maybe we can add some tests for mkMerge in the future.
delroth
added
the
12.approvals: 1
delroth
removed
the
12.approvals: 1
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#234615 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)