Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.72.1 -> 1.73.0 #259989

Merged
merged 1 commit into from
Oct 10, 2023
Merged

rustc: 1.72.1 -> 1.73.0 #259989

merged 1 commit into from
Oct 10, 2023

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Oct 9, 2023 •
edited
Loading

Description of changes

This upgrade unfortunately removes MIPS support, as it has been dropped to Tier 3 and so bootstrap tarballs are no longer provided.

It looks like it was dropped due to multiple codegen bugs, and lack of maintenance, so bringing it back would probably involve engaging with Rust/LLVM upstream on those.

  • fd on x86_64-darwin
  • fd on x86_64-linux
  • fd on aarch64-linux
  • firefox on x86_64-linux
  • thunderbird on x86_64-linux

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
rustc: 1.72.1 -> 1.73.0
4dd6fae 
This upgrade unfortunately removes MIPS support, as it has been
dropped to Tier 3[1] and so bootstrap tarballs are no longer provided.

It looks like it was dropped due to multiple codegen bugs, and lack of
maintenance, so bringing it back would probably involve engaging with
Rust/LLVM upstream on those.

[1]: rust-lang/compiler-team#648
@alyssais alyssais requested a review from a user October 9, 2023 13:07
RaitoBezarius
RaitoBezarius approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 9, 2023
@ofborg ofborg bot requested review from tjni and globin October 9, 2023 14:12
@alyssais alyssais mentioned this pull request Oct 9, 2023
Merged
47 tasks
@alyssais
Copy link
Member Author

alyssais commented Oct 9, 2023

Oh, one thing — usually we stick to the same LLVM as Rust upstream, but we don't have LLVM 17 yet (see #258614). IIRC we've been an LLVM behind for Rust before and it hasn't caused any problems.

@workingjubilee
Copy link

workingjubilee commented Oct 10, 2023 •
edited
Loading

Oh, one thing — usually we stick to the same LLVM as Rust upstream, but we don't have LLVM 17 yet (see #258614). IIRC we've been an LLVM behind for Rust before and it hasn't caused any problems.

Yes, in the general case we have tried to support using "today's LLVM and yesterday's LLVM" with rustc, with a "maybe" on yesteryear's LLVM. This has been really inconvenient sometimes with certain major LLVM changes like the opaque pointers or pass manager updates, making the results more "fun" for everyone, both compiler engineers and distro maintainers, but it seems nothing earthshattering is in LLVM 17, by comparison.

This is also part of why it's undesirable to have a mostly-unmaintained target being advertised as tier 2: even if all the codegen problems got patches in flight right now, they might not see a release until LLVM 18, depending on LLVM's patch cycle. So we'd only be confident we wouldn't get reports for them after we updated to LLVM 19 and then dropped LLVM 17.

figsoda
figsoda approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried testing on darwin, but the build box kept running out of disk space, lgtm on linux

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 10, 2023
@alyssais alyssais merged commit c11cb00 into NixOS:staging Oct 10, 2023
32 checks passed
@alyssais alyssais deleted the rustc-1.73.0 branch October 10, 2023 14:42
@FliegendeWurst FliegendeWurst mentioned this pull request Oct 10, 2023
Closed
1 task
@evanrichter
Copy link
Contributor

tried testing on darwin, but the build box kept running out of disk space, lgtm on linux

works for me on my aarch64-darwin host

@ghost
Copy link

ghost commented Oct 30, 2023

This upgrade unfortunately removes MIPS support, as it has been dropped to Tier 3 and so bootstrap tarballs are no longer provided.

😭

@colemickens colemickens mentioned this pull request Nov 5, 2023
Closed
13 tasks
@ghost
Copy link

ghost commented Nov 11, 2023

Heads up, this bump breaks cross compilation of crate2nix-driven projects in a very weird way:

If you use crate2nix to cross compile you might need to stick to 1.72.1 until we figure out what went wrong here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-get-latest-cargo-version/35406/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@zowoq zowoq Awaiting requested review from zowoq

@winterqt winterqt Awaiting requested review from winterqt

@Mic92 Mic92 Awaiting requested review from Mic92

@tjni tjni Awaiting requested review from tjni

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alyssais @workingjubilee @evanrichter @nixos-discourse @RaitoBezarius @figsoda @delroth