Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.{pprint,zelus-gtk}: disable for early versions of OCaml #260165

Merged
merged 2 commits into from
Oct 10, 2023
Merged

ocamlPackages.{pprint,zelus-gtk}: disable for early versions of OCaml #260165

merged 2 commits into from
Oct 10, 2023

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 10, 2023

because they won’t build…

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vbgl vbgl requested a review from ulrikstrid as a code owner October 10, 2023 07:33
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 10, 2023
@wegank wegank merged commit 458728a into NixOS:master Oct 10, 2023
10 checks passed
@vbgl vbgl deleted the ocaml-cleaning-2023-10-10 branch October 10, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbgl @wegank @delroth