-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdhtml: init at 0.2.2 #261671
mdhtml: init at 0.2.2 #261671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Just a few nits
Also, please rebase your commits to look like this:
|
I believe you have the commits in the wrong order. Other than that, it looks good to me. I don't think it's obligatory just yet, but a lot of packages tend to go into the new |
You don't need to do this now, there will be a later pr that moves everything possible via a script so don't bother for this pr, when you do another init just put it into pkgs/by-name since you don't have to edit the all-packages.nix |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes
mdhtml is a simple CLI Markdown to HTML converter with styling support.
https://codeberg.org/Tomkoid/mdhtml
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)