Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

konbucase: init at 4.1.1 #262315

Merged
merged 2 commits into from Oct 21, 2023
Merged

konbucase: init at 4.1.1 #262315

merged 2 commits into from Oct 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2023 •
edited by ghost
Loading

Description of changes

Add galaxy to maintainers list.
Add new package konbucase

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

h7x4
h7x4 reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran the application, seems to work fine. Just a small comment

@h7x4
Copy link
Member

h7x4 commented Oct 20, 2023

Result of nixpkgs-review pr 262315 run on x86_64-linux 1

1 package built:
  • konbucase

@ghost
Copy link
Author

ghost commented Oct 21, 2023

The checks of Darwin are stuck too long time.

@h7x4
Copy link
Member

h7x4 commented Oct 21, 2023

The checks of Darwin are stuck too long time.

They always are. Nothing to worry about

@wegank wegank merged commit a87cbeb into NixOS:master Oct 21, 2023
23 of 24 checks passed
@ghost ghost deleted the konbucase branch October 22, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h7x4 @delroth @wegank @NixOSInfra