Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darkman: add meta.mainProgram #262793

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Oct 22, 2023

Description of changes

Adds meta.mainProgram for darkman.
Motivation: home-manager uses getExe darkman, which results in warnings during builds.

With this change the warnings doesn't show up:

$ nix repl
Welcome to Nix 2.17.0. Type :? for help.

nix-repl> :l .
Added 19492 variables.

nix-repl> lib.getExe darkman 
"/nix/store/jzjs8b4rj6hfxvvf320ac9dw3z6ab8wb-darkman-1.5.4/bin/darkman"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank wegank merged commit a5427de into NixOS:master Oct 22, 2023
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants