liblogging: add withSystemd option #262840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
Artturin
reviewed
Oct 23, 2023
| @@ -1,5 +1,6 @@ | |||
| { lib, stdenv, fetchurl, pkg-config | |||
| , systemd ? null | |||
| , withSystemd ? true | |||
There was a problem hiding this comment.
Suggested change
| , withSystemd ? true | |
| , withSystemd ? lib.meta.availableOn stdenv.hostPlatform systemd |
There was a problem hiding this comment.
Thanks! This is one of those patches I'd been carrying since before meta.availableOn existed.
There was a problem hiding this comment.
I think you dropped this accidentally
ghost
requested a review
from
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
ghost
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
This allows to build liblogging on platforms where systemd does not compile.
Artturin
changed the title
Artturin
approved these changes
Oct 31, 2023
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This allows to build liblogging on platforms where systemd does not compile.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)