buildRustCrate: fix cross #264042
Closed
buildRustCrate: fix cross #264042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `cargo` / `rustc` were run while letting `cc-rs` guess what should be the linker, the cc, etc. In general, this works almost well, except when `cc-rs` is confused and does not. As we already do in many places in the Rust cross compilation ecosystem, we set certain environment variables which wraps any rustc or cargo invocation to help `cc-rs` or `cargo` understand what is the linker, etc. We proceed to do the same here.
RaitoBezarius
force-pushed
the
buildrustcrate-cross
branch
from
5984560
to
54916b2
Compare
ofborg
bot
added
the
6.topic: cross-compilation
|
This fixes nothing for now. |
ofborg
bot
added
10.rebuild-darwin: 0
|
@Ericson2314 I know you got crate2nix working with cross-compilation in https://github.com/alamgu/alamgu — would you happen to know if our |
|
@RaitoBezarius this can now be closed in favor of #220429? |
Absolutely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
cargo/rustcwere run while lettingcc-rsguess what should be the linker, the cc, etc.In general, this works almost well, except when
cc-rsis confused and does not.As we already do in many places in the Rust cross compilation ecosystem, we set certain environment variables which wraps any rustc or cargo invocation to help
cc-rsorcargounderstand what is the linker, etc.We proceed to do the same here.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)