vscode-extensions.vadimcn.vscode-lldb: fix passthru adapter #264887
Conversation
|
Result of 1 package failed to build:
|
mrcjkb
changed the title
| wrapProgram $out/bin/codelldb \ | ||
| --set-default LLDB_DEBUGSERVER_PATH "${lldb.out}/bin/lldb-server" | ||
| ln -s ${lldb.lib} $out/lldb | ||
| ln -s $out/lib/libcodelldb.so $out/bin/libcodelldb.so |
There was a problem hiding this comment.
libs should not be under bin
There was a problem hiding this comment.
I've added a comment explaining why codelldb won't work as a standalone if libcodelldb isn't symlinked to bin.
I've tried various other things (like prefixing LD_LIBRARY_PATH, passing in a flag), but none seem to work.
Do you have any ideas?
There was a problem hiding this comment.
Maybe we should put all files under $out/share/codelldb or similar and create a wrapper from that into $out/bin? Then we don't pollute the bin directory with unrelated files.
There was a problem hiding this comment.
That appears to work.
@Majiir does this work for you in VSCode?
There was a problem hiding this comment.
The plugin fails to build. I think you need to copy only ${adapter}/share/* instead of ${adapter}/{share,lib}/*, since there are files with the same name in both.
There was a problem hiding this comment.
Thanks - Should be fixed now.
There was a problem hiding this comment.
Builds and works in VSCode. 🚀
pkgs/applications/editors/vscode/extensions/vadimcn.vscode-lldb/default.nix
Show resolved
Hide resolved
mrcjkb
force-pushed
the
codelldb-fix
branch
2 times, most recently
from
de36c25 to
66ca0c0
Compare
pkgs/applications/editors/vscode/extensions/vadimcn.vscode-lldb/default.nix
Outdated
Show resolved
Hide resolved
|
Result of 1 package built:
|
|
Result of 1 package failed to build:
|
|
Result of 1 package built:
|
|
Result of 1 package built:
|
Description of changes
Fixes #160874.
See this comment: #160874 (comment)
To me this feels like a dirty hack, but it seems to work; and I can run
...where before it would complain about missing libraries.
The same hack is applied in the
installPhaseof the VSCode extension. (Maybe there's a cleaner way to do this?)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)