Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONTMERGE] PR to demonstrate qutebrowser cross compile #265401

Closed
wants to merge 20 commits into from
Closed

[DONTMERGE] PR to demonstrate qutebrowser cross compile #265401

wants to merge 20 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2023

Description of changes

This is the following two PRs together:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md

Adam Joseph added 7 commits November 3, 2023 22:28
Our qutebrowser package has been vandalized by various commits, such
as c9cc3a2 and
ad0bbaf, which made erroneous
assertions such as "since qutebrowser 3.0.0 the derivation is only
building for qt6."

This commit repairs the vandalism.
Adam Joseph and others added 13 commits November 4, 2023 15:22
…denvs

The main headache with cross-compiling QT is that our QT derivations
go bananas with propagatedInputs.  Unfortunately this means that
both buildPackages.qtbase and hostPackages.qtbase get propagated
into the dependencies of every cross-compiled builds, which triggers
the hook check.

Previously in #227900 I simply
disabled the check outright for cross-compiled builds.  This is a
more refined solution, where we skip the hook if it propagates
across a platform change.
@ghost
Copy link
Author

ghost commented Nov 4, 2023

@ofborg build pkgsCross.aarch64-multiplatform.qt5.qutebrowser

1 similar comment
@ghost
Copy link
Author

ghost commented Nov 4, 2023

@ofborg build pkgsCross.aarch64-multiplatform.qt5.qutebrowser

@ghost
Copy link
Author

ghost commented Nov 4, 2023

This works at d201256

  • pkgsCross.aarch64-multiplatform.qt5.qutebrowser on x86_64-linux — Success

@ghost ghost closed this Nov 12, 2023
@ghost ghost mentioned this pull request Nov 13, 2023
13 tasks
@ghost ghost deleted the qutebrowser-cross branch January 23, 2024 06:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant