-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONTMERGE] PR to demonstrate qutebrowser cross compile #265401
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldInputs if cross compiling
ofborg
bot
added
the
6.topic: cross-compilation
Building packages on a different platform than they will be used on
label
Nov 4, 2023
github-actions
bot
added
6.topic: python
6.topic: qt/kde
6.topic: lib
The Nixpkgs function library
labels
Nov 4, 2023
ofborg
bot
added
8.has: clean-up
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 2501-5000
labels
Nov 4, 2023
…denvs The main headache with cross-compiling QT is that our QT derivations go bananas with propagatedInputs. Unfortunately this means that both buildPackages.qtbase and hostPackages.qtbase get propagated into the dependencies of every cross-compiled builds, which triggers the hook check. Previously in #227900 I simply disabled the check outright for cross-compiled builds. This is a more refined solution, where we skip the hook if it propagates across a platform change.
@ofborg build pkgsCross.aarch64-multiplatform.qt5.qutebrowser |
1 similar comment
@ofborg build pkgsCross.aarch64-multiplatform.qt5.qutebrowser |
ghost
closed this
Nov 12, 2023
ghost
mentioned this pull request
Nov 13, 2023
13 tasks
ghost
deleted the
qutebrowser-cross
branch
January 23, 2024 06:51
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: cross-compilation
Building packages on a different platform than they will be used on
6.topic: lib
The Nixpkgs function library
6.topic: python
6.topic: qt/kde
8.has: clean-up
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 2501-5000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is the following two PRs together:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md