Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.tabula-py: 2.8.1 -> 2.8.2; fix build #265993

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

natsukium
Copy link
Member

Diff: chezou/tabula-py@refs/tags/v2.8.1...v2.8.2

Changelog: https://github.com/chezou/tabula-py/releases/tag/v2.8.2

ZHF: #265948
https://hydra.nixos.org/build/238995645

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 7, 2023
@natsukium
Copy link
Member Author

natsukium commented Nov 7, 2023

Result of nixpkgs-review pr 265993 at 5e2a477d run on aarch64-darwin 1

2 packages built successfully:
  • python310Packages.tabula-py
  • python311Packages.tabula-py

Result of nixpkgs-review pr 265993 at 5e2a477d run on x86_64-linux 1

2 packages built successfully:
  • python310Packages.tabula-py
  • python311Packages.tabula-py

@wamserma
Copy link
Member

wamserma commented Nov 7, 2023

Result of nixpkgs-review pr 265993 run on aarch64-linux 1

4 packages built:
  • python310Packages.tabula-py
  • python310Packages.tabula-py.dist
  • python311Packages.tabula-py
  • python311Packages.tabula-py.dist

@@ -39,11 +36,15 @@ buildPythonPackage rec {
setuptools-scm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add setuptools, as you're currently relying on setuptools-scm propagating it.

https://github.com/chezou/tabula-py/blob/v2.8.2/pyproject.toml#L2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@Artturin Artturin merged commit 55f883b into NixOS:master Nov 10, 2023
22 checks passed
@natsukium natsukium deleted the tabula-py/update branch November 11, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants