Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdfcxx4: fix build, add patch for cmake #266076

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Nov 7, 2023

The fix in the patch is picked from upstream.
Can be removed with next release.
(Upstream commit does not apply; contains more changes)

ZHF #265948

EDIT: mark broken on Darwin. I am not able to fix Darwin build failures.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The fix in the patch is picked from upstream.
Can be removed with next release.
(Upstream commit does not apply; contains more changes)
@markuskowa
Copy link
Member Author

@GrahamcOfBorg build cdo

@markuskowa markuskowa merged commit 8458b6a into NixOS:master Nov 10, 2023
22 of 23 checks passed
@markuskowa markuskowa deleted the fix-netcdfcxx branch November 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant