Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaom: fix cross #266257

Merged
merged 1 commit into from Nov 19, 2023
Merged

libaom: fix cross #266257

merged 1 commit into from Nov 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2023

Description of changes

Apparently the CMake variable for indicating the assembler has changed from AS_EXECUTABLE to CMAKE_ASM_COMPILER.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Apparently the CMake variable for indicating the assembler has
changed from `AS_EXECUTABLE` to `CMAKE_ASM_COMPILER`.
@ghost ghost marked this pull request as ready for review November 8, 2023 12:10
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 8, 2023
@NickCao
Copy link
Member

NickCao commented Nov 8, 2023

@ofborg build pkgsCross.aarch64-multiplatform.libaom

@Artturin
Copy link
Member

Artturin commented Nov 8, 2023

CI failed

CMake Error at build/cmake/aom_configure.cmake:192 (message):
  Unable to find assembler and optimizations are enabled.Searched for as.
  Install it, add it to your path, or set the assembler directly by adding
  -DAS_EXECUTABLE=<assembler path> to your CMake command line.To build
  without optimizations, add -DAOM_TARGET_CPU=generic to your cmake command
  line.
Call Stack (most recent call first):
  CMakeLists.txt:66 (include)

pkgsCross.aarch64-multiplatform.libaom builds on master

@ghost ghost marked this pull request as draft November 9, 2023 01:06
@uninsane
Copy link
Contributor

pkgsCross.aarch64-multiplatform.libaom does not build from x86_64 for me on master (653e323). this patch fixes it.

@Artturin
Copy link
Member

That's true, dunno what happened.

@Artturin Artturin marked this pull request as ready for review November 19, 2023 00:21
@Artturin Artturin merged commit cc27610 into NixOS:master Nov 19, 2023
28 checks passed
@ghost ghost deleted the pr/libaom/fixcross branch January 23, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants