Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.cross.sanity: add test case for #267859 #268018

Merged
merged 1 commit into from Nov 19, 2023
Merged

tests.cross.sanity: add test case for #267859 #268018

merged 1 commit into from Nov 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2023

Working on a fix. This ensures that it will stay fixed.

Description of changes

This commit adds pkgs.spike, which internally uses pkgsCross.riscv64-embedded.stdenv.cc, as a test case for the issue reported in #267859

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This commit adds pkgs.spike, which internally uses
pkgsCross.riscv64-embedded.stdenv.cc, as a test case for the issue
reported in #267859
@ghost ghost marked this pull request as ready for review November 17, 2023 04:02
@ghost ghost marked this pull request as draft November 17, 2023 04:11
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 17, 2023
@ghost ghost marked this pull request as ready for review November 17, 2023 04:39
@Artturin Artturin merged commit 0192fcc into NixOS:master Nov 19, 2023
24 checks passed
@ghost ghost deleted the pr/testcase/267859 branch November 19, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant