Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.cross.sanity: add pkgs.pkgsCross.musl64.crosvm #268061

Closed
wants to merge 1 commit into from
Closed

tests.cross.sanity: add pkgs.pkgsCross.musl64.crosvm #268061

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2023

Description of changes

Should pass as soon as

is merged.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Nov 17, 2023
@ghost ghost marked this pull request as ready for review November 17, 2023 08:39
@ghost ghost requested a review from alyssais November 17, 2023 08:39
@ghost
Copy link
Author

ghost commented Nov 17, 2023

Hrm, I think we might be passing --sysroot twice in some situations. pkgsCross.musl64.crosvm gives me:

error: build of '/nix/store/v35dqc9xc7hv40m5544w9qhwafbnk62c-rustc-x86_64-unknown-linux-musl-1.73.0.drv' on 'ssh://root@192.168.22.106' failed: builder for '/nix/store/v35dqc9xc7hv40m5544w9qhwafbnk62c-rustc-x86_64-unknown-linux-musl-1.73.0.drv' failed with exit code 2
error: builder for '/nix/store/v35dqc9xc7hv40m5544w9qhwafbnk62c-rustc-x86_64-unknown-linux-musl-1.73.0.drv' failed with exit code 1;
       last 10 log lines:
       > Building stage0 library artifacts (x86_64-unknown-linux-gnu)
       > error: failed to run `rustc` to learn about target-specific information
       >
       > Caused by:
       >   process didn't exit successfully: `/build/rustc-1.73.0-src/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names -Ccodegen-units=10 -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(stdarch_intel_sde)' '--check-cfg=values(no_fp_fmt_parse)' '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(no_rc)' '--check-cfg=values(no_sync)' '--check-cfg=values(freebsd12)' '--check-cfg=values(freebsd13)' '--check-cfg=values(backtrace_in_libstd)' '--check-cfg=values(target_vendor,"unikraft")' '--check-cfg=values(target_env,"libnx")' '--check-cfg=values(target_os,"teeos")' '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","xtensa","mips32r6","mips64r6","csky")' -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Ctarget-feature=-crt-static -Cprefer-dynamic -Zinline-mir '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/1.73.0/")' --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
       >   --- stderr
       >   error: Option 'sysroot' given more than once
       >
       > Build completed unsuccessfully in 0:00:49
       > make: *** [Makefile:12: all] Error 1
       For full logs, run 'nix log /nix/store/v35dqc9xc7hv40m5544w9qhwafbnk62c-rustc-x86_64-unknown-linux-musl-1.73.0.drv'.
error: 1 dependencies of derivation '/nix/store/8wyqp47m4pi46q0r2xx88lffabjj2yl5-rustc-wrapper-1.73.0.drv' failed to build

@ghost ghost closed this Jan 23, 2024
@ghost ghost deleted the pr/sanity/musl64.crosvm branch January 23, 2024 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants